Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell based completion path selection #521

Conversation

j0yu
Copy link
Contributor

@j0yu j0yu commented Aug 20, 2018

Basic selection logic to output the relevant shell completion command.

@skral, would this be of interest to #496 ?

@skral
Copy link
Contributor

skral commented Aug 20, 2018

@j0yu I don't see a relation between these PRs but I might be wrong. Do you see one?

@j0yu
Copy link
Contributor Author

j0yu commented Aug 21, 2018

Hello @skral,

Sorry, I'm still fairly new to setting up and tinkering with the backend of rez.

I was thinking of utilising the additional tests of various shells in #496 as this will output different texts to stdout based on different shells.

Then again in regards to tests, the changes I introduced would probably come under a test specifically for installation rather than the selftest?

@skral
Copy link
Contributor

skral commented Aug 22, 2018

@j0yu You're right there is no installation specific test yet. #496 makes sure all shells rez supports are available in the CI environment on Linux and OSX, installs rez and runs selftest. I think it would be great to have some installation specific tests to check the integrity of rez after the installation, I don't remember seeing any PR including that yet though.

@nerdvegas nerdvegas merged commit 64f7321 into AcademySoftwareFoundation:master Sep 5, 2018
@j0yu j0yu deleted the feature/install-completion branch September 5, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants